Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API DTO Implementation #32

Merged
merged 5 commits into from
Apr 26, 2024
Merged

API DTO Implementation #32

merged 5 commits into from
Apr 26, 2024

Conversation

haimkastner
Copy link
Owner

@haimkastner haimkastner commented Mar 8, 2024

The JS implementation of #31
See also the discussion on angularsen/UnitsNet#1378

Copy link

@Shentoza Shentoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, appreciate the effort!

@haimkastner haimkastner changed the title Draft of #31 implementation API DTO Implementation Mar 9, 2024
@Shentoza
Copy link

Any ETA on this PR? Does it have blockers that you could need help with?

@haimkastner
Copy link
Owner Author

@Shentoza
The PR is ready to be merged.

But as I aim to make it cross-technologies, I'm waiting for the UnitNet C# owner to provide their input before publishing and committing to the new API.

Since I don't know when he will give his input, if it helps, I can publish the new API as a beta release, with no guarantee of slight changes before the final release (unlikely, but still possible)

WDYT?

@Shentoza
Copy link

That makes totally sense to wait if the C# package owner agrees to your approach, which would be great. For now i have a working solution™, so it's not urgent, and I will just swap out once this PR completes.

@Shentoza
Copy link

since I seem to be the only one interested in this change, i dont think it justifies a beta/bleeding edge branch and for stability reasons, i would wait for the stable release anyway, so i dont have to update twice

@haimkastner haimkastner merged commit 1f97d22 into master Apr 26, 2024
2 checks passed
@haimkastner haimkastner deleted the implement-dto branch April 26, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants