Fix transport for curvilinear grids #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmans2
requested review from
asiddi24,
Mikejmnez,
renskegelderloos and
ThomasHaine
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the function that computes transports when using curvilinear grids (the regional setups with rectilinear grids are not affected).
The issue is that currently OceanSpy infers whether path segments are aligned with the X or Y axis using latitude and longitude.
This does not work with curvilinear grids, as the segments might not be zonal/meridional.
The fix is quite straightforward though. We just have to keep track of the indexes (X/Yind variables are now added to the
OceanDatasetbysubsample.mooring_array). These indexes will then be used bycompute.mooring_volume_transportto infer the orientation of the segments.This plot shows the bug:
This plot shows the fix:
Sorry, the plots are not great but if you zoom on
Path 0you should be able to see what's wrong.