Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved behavior of subsample.mooring #364

Merged
merged 14 commits into from
May 26, 2023
Merged

Conversation

Mikejmnez
Copy link
Collaborator

@Mikejmnez Mikejmnez commented May 26, 2023

Closes #362

It also improves the behavior of mooring (and cutout) when handling complex mooring array paths, which can cross the 0 or 180 degree longitude multiple times.

See for example the following arrays using the ECCO dataset (patterns were chosen from Poseidon viewer seen in top left):

examples

@Mikejmnez Mikejmnez temporarily deployed to pypi May 26, 2023 02:58 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #364 (d7acc82) into main (cff27a3) will decrease coverage by 0.16%.
The diff coverage is 90.66%.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   94.68%   94.53%   -0.16%     
==========================================
  Files           9        9              
  Lines        3954     3971      +17     
  Branches      933      943      +10     
==========================================
+ Hits         3744     3754      +10     
- Misses        132      137       +5     
- Partials       78       80       +2     
Flag Coverage Δ
unittests 94.53% <90.66%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/utils.py 86.89% <85.10%> (-1.71%) ⬇️
oceanspy/llc_rearrange.py 82.64% <100.00%> (-0.03%) ⬇️
oceanspy/subsample.py 96.50% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. Thanks @Mikejmnez !

@Mikejmnez Mikejmnez merged commit a043890 into hainegroup:main May 26, 2023
@Mikejmnez Mikejmnez deleted the dev branch May 26, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poseidon Viewer yields lon values out of range of LLC-datasets
2 participants