-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved behavior of subsample.mooring #364
Conversation
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 94.68% 94.53% -0.16%
==========================================
Files 9 9
Lines 3954 3971 +17
Branches 933 943 +10
==========================================
+ Hits 3744 3754 +10
- Misses 132 137 +5
- Partials 78 80 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go. Thanks @Mikejmnez !
Closes #362
It also improves the behavior of mooring (and cutout) when handling complex mooring array paths, which can cross the 0 or 180 degree longitude multiple times.
See for example the following arrays using the ECCO dataset (patterns were chosen from Poseidon viewer seen in top left):