Plugin: Math - Support European-style decimal separator #268
Conversation
* Autodetect input mode - UK-style decimal separator "." (current) or European-style decimal separator "," (new) - and ensure the calculation and output matches what the user expects. Follows the suggested implementation from the MathJS library documentation: http://mathjs.org/examples/browser/custom_separators.html.html
|
I also bolded the calculation result! |
| try { | ||
| let query = rawQuery; | ||
|
|
||
| // determine input mode by the presence of European-style decimal separators |
There was a problem hiding this comment.
Why not use Intl.NumberFormat?
console.log((new Intl.NumberFormat()).resolvedOptions());
Shows this on my system (I believe it gets it from the system)
{ locale: 'und',
numberingSystem: 'latn',
style: 'decimal',
useGrouping: true,
minimumIntegerDigits: 1,
minimumFractionDigits: 0,
maximumFractionDigits: 3 }
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NumberFormat
There was a problem hiding this comment.
@cpriest it's an interesting suggestion, but I prefer my solution as:
- it is simpler, and more likely to work across platforms
- it allows users to utilise either decimal point or comma independently of whatever the system locale might be set to
There was a problem hiding this comment.
@cpriest are you happy for this to be merged as-is?
There was a problem hiding this comment.
I'd prefer it be more internationally useful, but I don't have a lot of conviction for it, so I'm fine with it. (I have no personal experience with Internationalization, but a lot of other people do care.)
|
looks good to me 👍 |
Follows the suggested implementation from the MathJS library documentation: http://mathjs.org/examples/browser/custom_separators.html.html
Implements #246