strings.Indent should not indent when width is 0 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recursively generating YAML, it is useful to have a simple generic template definition that starts with an indent of 0 and increments at each level YAML. If you pass `width` of 0 to the function as it was before this change, it would indent it one level without complaining, which was a great source of confusion to me.
hairyhenderson
changed the title
|
Hi @keitwb! Thanks for taking the time to fix this. Not only is this confusing - it's a bug 😉 |
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recursively generating YAML, it is useful to have a simple generic template definition that starts with an indent of 0 and increments at each level YAML. If you pass
widthof 0 to the function as it was before this change, it would indent it one level without complaining, which was a great source of confusion to me.