New git datasource #661
Merged
New git datasource #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Nov 9, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
hairyhenderson
force-pushed
the
git-datasource
branch
2 times, most recently
from
859b2fc to
b285c11
Compare
hairyhenderson
force-pushed
the
git-datasource
branch
from
4a1e8ef to
5dc794e
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
git-datasource
branch
from
5dc794e to
744dfe2
Compare
rossedman
reviewed
Nov 12, 2019
Comment on lines
+59
to
+71
| func (g gitsource) parseArgURL(arg string) (u *url.URL, err error) { | ||
| if strings.HasPrefix(arg, "//") { | ||
| u, err = url.Parse(arg[1:]) | ||
| u.Path = "/" + u.Path | ||
| } else { | ||
| u, err = url.Parse(arg) | ||
| } | ||
|
|
||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to parse arg %s: %w", arg, err) | ||
| } | ||
| return u, err | ||
| } |
|
@hairyhenderson This looks really awesome, thanks for throwing this up. I like where it's heading. |
|
Thanks @rossedman! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for accessing datasources in git repos. Adds 5 new schemes:
git://- the git server (as served bygit daemonand others)git+file://- git repo on the local filesystem - supports bare repos as wellgit+ssh://- git over sshgit+http://,git+https://- git over http(s)//is used to separate repo from path, likegit+https://github.com/example/repo//path/to/file.yaml- the path here is/path/to/file.yaml. Directories are supported.Signed-off-by: Dave Henderson dhenderson@gmail.com