Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce postgres support #560

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

justjanne
Copy link

@justjanne justjanne commented Jun 13, 2022

In Short

  • Updates all places where postgres queries were out of sync with other databases
  • Introduces new postgres queries in places where they weren’t supported before
  • Updates all table creation logic for postgres
  • Introduces rudimentary support for postgres in tests
  • Updates all REPLACE INTO statements to support postgres properly as well
  • Updates the new database backend to support postgres
  • Implements the new query logic for postgres
  • Validate and test the changes
  • Ensure postgres support in Seahub and Seafdav as well
  • Ensure users upgrading from older versions are supported as well

Related

haiwen/seafdav#66
haiwen/seahub#5196

Rationale

Many users (me included) use Seafile with PostgreSQL databases. Seafile has supported Postgres databases with small patches for many years, but during a recent db backend rewrite that functionality got removed. My own deployment has been stuck on 7.0, with no update in sight.

Due to that, I’ve decided to implement Postgres support back into Seafile. If it doesn’t get merged, I’ll have to maintain a custom fork with downstream patches, which I’d like to avoid.

@justjanne justjanne marked this pull request as ready for review June 13, 2022 21:41
@justjanne justjanne changed the title WIP: Reintroduce postgres support Reintroduce postgres support Jun 13, 2022
@justjanne justjanne marked this pull request as draft June 13, 2022 22:15
@justjanne justjanne marked this pull request as ready for review June 13, 2022 22:46
@justjanne justjanne marked this pull request as ready for review June 14, 2022 19:48
@justjanne
Copy link
Author

@haiwen I’d like to request a review for this PR and the related PRs. If you’d find time to take a look at these, that’d be great!

I know that even with these patches the PE won’t support postgres, but it’d be great to have at least postgres support in the CE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant