Fixing things I screwed up with evhtp. #1462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- By screwing up, I mean, a total lack of communication about this change. And I wasn't aware of th problem until just now. But that's no excuse. The semi-explaination I posted here: explaination can be found here: #1119 Which links to another 500 page issue that caused the logic to change, ever so slightly, an issue that sneaks up on you if unaware (thus my apologies for the lack of communication) Kinda like the day I broke tor. Gist is, you can get into a state of hung connections if you send data right ifter a resume. You have to treat it like pending data, then emit it to get the event loop rolling again. I'm pretty sure this should fix the problem, if not, we have some more safety nets in our develop tree which may further the bugginess of resumption + pipelining.
|
Have already tested this change yesterday and unfortunately the problem persists. |
|
Next parch in a bit On Sun, Nov 29, 2015 at 6:53 AM Ultima1252 notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By screwing up, I mean, a total lack of communication about this change. And I
wasn't aware of th problem until just now. But that's no excuse.
The semi-explaination I posted the problem and solution here:
Self-compiled Seafile fileserver does not respond, web downloads hang #1119
Which links to another 500 page issue that caused the logic to change, ever so
slightly, an issue that sneaks up on you if unaware (thus my apologies for the
lack of communication)
Kinda like the day I broke tor.
Gist is, you can get into a state of hung connections if you send data right ifter a
resume. You have to treat it like pending data, then emit it to get the event
loop rolling again.
I'm pretty sure this should fix the problem, if not, we have some more safety
nets in our develop tree which may further fix the bugginess of resumption +
pipelining.