You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To be honest, I'm not sure. It feels like the possible outcome of a getMap request and the structure of the userDetails object will differ a lot between implementations. E.g. here's how it looks on one AD setup:
Perhaps we should come up with a common interface for this object?
One thing that comes into mind: if you active to show the button with user initials, what does it say in your setup?
I'm wondering because I notice that I'm utilising the displayName field, as well as the description field, both of which are lacking in your screenshot. Instead you have some fields that I haven't seen before.
As stated previously, I think we should agree upon some interface for userDetails. Perhaps sAMAccountName, mail, displayName and description should always be available?
Actually I have never seen the "button with user initials".
Well, that would be nice. But it would mean even more changes to NodeHoster and even more data will be send on every request through the proxy. Then it will need to be handled in nodebackend as well.
As I cant prioritize this right now and it's not urgent, I would prefer more additions to userDetails as a new issue in both Hajk-repo and NodeHoster-repo. What do you think?
When using the built in AD lookup in the backend you can activate userDetails to get a bunch of stuff from AD related to the user.
When using the
AD_USE_GROUPS_FROM_HEADER=true
funtionality this is currently not possible.But.... we could add userName and groups to the userDetails object, and after this PR in NodeHoster you could also get the users email.
Proposal for object in returned config:
Proposal for default env variable:
AD_TRUSTED_EMAIL_HEADER=X-Control-Email-Header
The text was updated successfully, but these errors were encountered: