Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1533 user details for ad header approach #1534

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Feature/1533 user details for ad header approach #1534

merged 6 commits into from
Jul 2, 2024

Conversation

jesade-vbg
Copy link
Contributor

@jesade-vbg jesade-vbg commented Jun 26, 2024 •
edited
Loading

Closes #1533

@jesade-vbg
Copy link
Contributor Author

Tested and now running live in vbg "Geodatabank". Will remove Draft status now.

@jesade-vbg jesade-vbg marked this pull request as ready for review June 26, 2024 12:44
@jacobwod
Copy link
Member

jacobwod commented Jul 1, 2024

Hi @jesade-vbg! So what do you think about the comments I left in #1533? I'm thinking of the part about a "standardised contract", i.e. that we try to make both ad.getUserDetails() and ad.findUser() return pretty much the same objects, or at least match some "most important" keys?

jacobwod
jacobwod previously approved these changes Jul 2, 2024
View reviewed changes
@jacobwod
Copy link
Member

jacobwod commented Jul 2, 2024

Uh, don't forget to add a line to the CHANGELOG @jesade-vbg! 😄

@jesade-vbg jesade-vbg requested a review from jacobwod July 2, 2024 08:32
@jesade-vbg jesade-vbg merged commit 4c57949 into develop Jul 2, 2024
@jesade-vbg jesade-vbg deleted the feature/1533-userDetails-for-ad-header-approach branch July 2, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobwod jacobwod jacobwod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesade-vbg @jacobwod