Update EntityManager to use a read-only wrapper over entity groups #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Look into if there's an interface to implementtoArray()
andforEach()
just so we can be consistent with other iterable objectsMakes it a lot nicer to work with the EntityManager for queries now
becomes:
Also, because the query doesn't directly pass back the map anymore, this group is basically a read-only copy. The only remaining gotcha now is that if users store this group, they could be surprised that it changes over time as entities are modified since the
.get()
method is really accessing a group reference underneathTo combat that issue, users can create their own copies of the contents of the query/group:
(since
Array.from()
will work on anything that implementsIterable
)Also adds in a
.toArray()
and.forEach()
function