Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hakandilek. Here are two projects: twixt54 is a play module,and m8 is a play app.
Steps
-build and publish-local twixt54
-build m8
Both these projects have play2-crud as a dependency
The key line is in m8 TaxiController.java.
public class TaxiController extends MyDynamicTwixtController<Long, Taxi, TaxiTwixt>
When the controller is derived from the local class MyDynamicTwixtController, everything works fine and the
ClasspathScanningControllerRegistry sees TaxiController:
[debug] p.u.m.c.ClasspathScanningControllerRegistry - pqpcontrollerClass : class
controllers.TaxiController
But when TaxiController is changed to derive from DynamicTwixtController (in twixt54), then ClasspathScanningControllerRegistry does not see TaxiController. I am no longer seeing an exception, but play2-crud simply ignores TaxiController and generates its own. This is incorrect; it should see that TaxiController is a crud controller for the Taxi model.