Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slidechanged event before "current-fragment" is set #2439

Open
gabyx opened this issue Jun 19, 2019 · 0 comments
Open

slidechanged event before "current-fragment" is set #2439

gabyx opened this issue Jun 19, 2019 · 0 comments

Comments

@gabyx
Copy link

gabyx commented Jun 19, 2019

The reveal-code-focus Plugin issue: bnjmnt4n/reveal-code-focus#20
Is related to the fact that the dispatch of the event "slidechanged" happens before updateFragments() is called, and the current-fragment is at this point is not set in the DOM.

In this way when going to a previous slide, the plugin cannot detect the "current-fragment" which it needs to "focus code"...

Shouldnt it be much better to emit the "slidechanged" after all update functions??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant