Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Internal Links not working #20

Open
gabyx opened this issue Jun 19, 2019 · 1 comment
Open

Internal Links not working #20

gabyx opened this issue Jun 19, 2019 · 1 comment
Labels

Comments

@gabyx
Copy link

gabyx commented Jun 19, 2019

Having internal links to certain fragments will not work with this plugin, since:
the code in updateCurrentSlide makes a call to

 while (Reveal.nextFragment()) {}

which will neglect fragment numbers. How can we fix that, I think, that the code is wrong, and we should only highlight the code up to the current fragment index,...

@bnjmnt4n
Copy link
Owner

bnjmnt4n commented Aug 9, 2019

The reason why I wrote that code was to ensure that when navigating backwards to a previous slide, the current-fragment class was not set, as you’ve spotted in hakimel/reveal.js#2439. I guess I haven’t thought of the situation of linking to fragments. Will have to think about how to implement this properly and think of a fix for Reveal.js as well.

bnjmnt4n added a commit that referenced this issue Aug 10, 2019
…fragment when slides are changed.

This removes code that previously incorrectly manipulated fragments when
navigating to a prior slide.

Closes #20, #21.
bnjmnt4n added a commit that referenced this issue Aug 11, 2019
…works accurately.

When navigating from 1 fragment to another while skipping fragments in
between, the 'fragmentshown' and 'fragmenthidden' event handlers will
include all fragments in between. This commit modifies the handler code
to only focus on lines from the relevant fragments.

Closes #20, #21.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants