Correctly strip leading white-space from markdown #1831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the markdown contains something that is indented by more that the
`leadingTabs`/`leadingWs` then extra white space is incorrectly removed.
ie the following example:
```
<section data-markdown>
some text
indented text
more indented text
</section>
```
would result in the following markdown:
```
some text
indented text
more indented text
```
We can work around this problem by using a function to generate the
replace value.
|
This patch does fixes the problem for markdown plugin, but it has conflicts, I've resubmitted it here (and kept the original author), hope someone can take a look, thank in advance! |
|
This commit was merged via #3358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the markdown contains something that is indented by more that the
leadingTabs/leadingWsthen extra white space is incorrectly removed. ie the following example:would result in the following markdown:
We can work around this problem by using a function to generate the
replace value.