Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Boolean (data-)attributes will now be added to elements, too. #2515

Merged

Conversation

DenizThatMenace
Copy link
Contributor

When converting Markdown to HTML, boolean attributes (whose names start with data-...) will also be added to the resulting HTML elements, when attached via the <!-- .element: ... syntax.

Additionally, values of non-boolean attributes may now contain =. (fixes #2038)

@DenizThatMenace
Copy link
Contributor Author

Note: This pull-request slightly touches #2064, but sadly does not fix it, too, because that problem is harder to solve and seems to involve hacking into marked.js.

@hakimel hakimel merged commit 6fa7700 into hakimel:dev Mar 3, 2020
@hakimel
Copy link
Owner

hakimel commented Mar 3, 2020

Great fix, thanks!

@DenizThatMenace DenizThatMenace deleted the boolean-attributes-from-markdown branch May 25, 2020 11:20
@Xanderthepoison
Copy link

'E-merging' technology

R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this pull request Jun 7, 2021
…-markdown

Markdown: Boolean (data-)attributes will now be added to elements, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants