Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow slides to be uncounted #2543

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

lassepe
Copy link
Contributor

@lassepe lassepe commented Dec 4, 2019

Sometimes it is useful to mark slides as uncounted, e.g. if one wishes to add backup/appendix slides but want's the progress bar to reflect the progress of "non-appendix" slides (c.f. #1341). This PR adds the possibility of marking a slide with class .uncounted to achieve this. Currently people seem to use hacks like #1341 (comment) which has other side affects and only works for horizontal slides.

@hakimel hakimel changed the base branch from master to dev March 5, 2020 12:54
@hakimel hakimel merged commit 4b888d8 into hakimel:dev Mar 5, 2020
@lassepe lassepe deleted the feature/uncounted-slides branch March 5, 2020 13:09
@hakimel
Copy link
Owner

hakimel commented Mar 5, 2020

This has been merged with some changes. Instead of <section class="uncounted"> you'll need to add <section data-visibility="uncounted">. I switched to an attribute because so that we can reuse the same attribute when we eventually make it possible to fully hide a slide with data-visibility="hidden".

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants