fix: download linked objects in a WFS using "resolvedepth"

[emanuelaepure10]

Using "resolvedepth" when trying to download data via WFS is now downloading the linked objects. As the requested hits to a WFS is better to be setup to UNKNOWN_SIZE, so the size comes as well to be always UNKNOWN_SIZE, the code related to hits and size has been removed and the related methods have been changed accordingly.

ING-4128
Closes #1084

[emanuelaepure10]

@stempler Any idea why my PRs are always failing with the same error in the "Comment with links to the artifacts"?
Thank you

[florianesser]

Commit message and PR should reference the related GitHub issue #1084

[emanuelaepure10]

Or if we just setup the hits to UNKNOWN_SIZE, then the ignoreNumberMatched box doesn't make any sense because wont be used.

[emanuelaepure10]

@florianesser I have squashed the previous commit and this one just to be able to better see the change.

[florianesser]

LGTM

[emanuelaepure10]

@stempler does it happened to remember if there is somewhere a test example that contains "additionalObjects"? Thanks

[emanuelaepure10]

@stempler that should be hopefully the last and complete version. Please let me know if there is anything else to add.
Thank you for your support

[emanuelaepure10]

It seems that the following three tests are failing:

StreamGmlWriterTest.testGeometryPrimitive_32_MultiPolygon_WindingOrder_CW
StreamGmlWriterTest.testGeometryPrimitive_32_MultiPolygon_WindingOrder 
StreamGmlWriterTest.testGeometryPrimitive_32_MultiPolygon_WindingOrder_CCW

However, these tests are passing successfully on my local environment.

Do you have any suggestions on what might be causing the failures and how to resolve them?

[emanuelaepure10]

It appears that 3 tests are failing.
When I run the tests locally, all 16 tests in the StreamGmlWriterTest class pass successfully.

Could you provide some guidance on what might be causing these failures and how I can resolve them?

[stempler]

Could you provide some guidance on what might be causing these failures and how I can resolve them?

No clue at the moment what could be the issue. I retriggered the check but same result.
I ported the change to hale-core, I don't have the result on the CI yet, but locally these three tests also failed.

It seems to be a side effect of other tests running:

• if I only run one of the tests it works
• if I run only this test class it works
• if I run all tests from this project these three tests fail (Update: but not every time)

[emanuelaepure10]

test this please

[stempler]

To rerun the GitHub actions job when there were failures you can just open the workflow run and select "Rerun jobs" -> "Rerun failed jobs".

[emanuelaepure10]

@stempler @florianesser
I temporarily removed the test in StreamGmlReaderTest', which was already commented as something to be moved when the services were no longer functional. This seems to have resolved the issue. However, I still don’t see how this is related to the failure of the other three tests in StreamGmlWriterTest.

LE: I was wrong. Sorry for disturbing, the error is still there.

[we-release]

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

• v5.4.0
• GitHub release

Your semantic-release bot 📦🚀