Skip to content

Commit

Permalink
Default WITH_TEST_FUZZ to OFF (#7695)
Browse files Browse the repository at this point in the history
* Fix for top-of-tree LLVM

* Default WITH_TEST_FUZZ to OFF

Just because our compiler supports fuzzing doesn't mean we want to build the fuzz tests, because they won't really build properly without the right preset specified.

(This will be followed up with a change to the buildbot to set WITH_TEST_FUZZ to ON for fuzz tests)
  • Loading branch information
steven-johnson authored Jul 26, 2023
1 parent bfc26cc commit 09c5d1d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,12 @@ else ()
message(VERBOSE "Compiler supports libfuzzer sanitizer.")
endif ()

# Note that we want to default WITH_TEST_FUZZ to OFF, even if HAS_FUZZ_FLAGS
# is true: just because our compiler supports fuzzing doesn't mean we want to
# build the fuzz tests, because they won't really build properly without the
# right preset specified.
cmake_dependent_option(
WITH_TEST_FUZZ "Build fuzz tests" ON
WITH_TEST_FUZZ "Build fuzz tests" OFF
HAS_FUZZ_FLAGS OFF
)

Expand Down

0 comments on commit 09c5d1d

Please sign in to comment.