compute_remainder_modulus analysis fails for cast<int>(some float) #2

abadams · 2012-07-31T19:50:14Z

This was a bug listed on the trello board. It needs to be tested to see if it's still a bug and fixed if so.

Add Arg expression for Scalar arguments - Add Arg expression to IR, codegen - Add int32, int64 Scalar Arg unpacking to c wrapper function interface - Pass dynamic width/height/channels as Scalar args in brightness example and cg_test_runner.cpp

abadams · 2012-08-05T16:29:59Z

Turns out it was fixed a while ago. Also added compute_remainder_modulus for Calls, which was failing.

Merge from mainline

BGR2Gray Halide+OpenCV sample

Hex dma2 copy to device prob

Sync

Previous fix broke LLVM 11 (I was too eager to land, sorry)

Patch auto-scheduler the random seed for weight generation is configurable via the HL_RANDOM_WEIGHT_SEED env variable.

Automake libruntime.a

Refactored buffers

* Export HalidePythonExtensionHelpers.cmake for installs * oops * fixes * Fix broken code in target_export_script() * oops #2 * Add WITH_SOABI to stubs as well as AOT * More fixes * Update CMakePresets.json * Update CMakePresets.json

This PR started out as a quick fix to add Python bindings for the `add_requirements` methods on Pipeline and Generator (which were missing), but expanded a bit to fix other issues as well: - The implementation of `Generator::add_requirement` was subtly wrong, in that it only worked if you called the method after everything else in your `generate()` method. Now we accumulate requirements and insert them at the end, so you can call the method anywhere. - We had C++ methods that took both an explicit `vector<Expr>` and also a variadic-template version, but the former required a mutable vector... and fixing this to not require that ended up creating ambiguity about which overloaded call to use. Added an ugly enable_if thing to resolve this. (Side note #1: overloading methods to have both templated and non-templated versions with the same name is probably something to avoid in the future.) (Side note #2: we should probably thing more carefully about using variadic templates in our public API in the future; we currently use it pretty heavily, but it tends to be messy and hard to reason about IMHO.)

* add_requirement() maintenance This PR started out as a quick fix to add Python bindings for the `add_requirements` methods on Pipeline and Generator (which were missing), but expanded a bit to fix other issues as well: - The implementation of `Generator::add_requirement` was subtly wrong, in that it only worked if you called the method after everything else in your `generate()` method. Now we accumulate requirements and insert them at the end, so you can call the method anywhere. - We had C++ methods that took both an explicit `vector<Expr>` and also a variadic-template version, but the former required a mutable vector... and fixing this to not require that ended up creating ambiguity about which overloaded call to use. Added an ugly enable_if thing to resolve this. (Side note #1: overloading methods to have both templated and non-templated versions with the same name is probably something to avoid in the future.) (Side note #2: we should probably thing more carefully about using variadic templates in our public API in the future; we currently use it pretty heavily, but it tends to be messy and hard to reason about IMHO.) * tidy * remove underscores

Some sneakiness going on.

* Fix float16 under asan, attempt #2 Some sneakiness going on. * Update float16_t.cpp

* Export HalidePythonExtensionHelpers.cmake for installs * oops * fixes * Fix broken code in target_export_script() * oops halide#2 * Add WITH_SOABI to stubs as well as AOT * More fixes * Update CMakePresets.json * Update CMakePresets.json

* add_requirement() maintenance This PR started out as a quick fix to add Python bindings for the `add_requirements` methods on Pipeline and Generator (which were missing), but expanded a bit to fix other issues as well: - The implementation of `Generator::add_requirement` was subtly wrong, in that it only worked if you called the method after everything else in your `generate()` method. Now we accumulate requirements and insert them at the end, so you can call the method anywhere. - We had C++ methods that took both an explicit `vector<Expr>` and also a variadic-template version, but the former required a mutable vector... and fixing this to not require that ended up creating ambiguity about which overloaded call to use. Added an ugly enable_if thing to resolve this. (Side note halide#1: overloading methods to have both templated and non-templated versions with the same name is probably something to avoid in the future.) (Side note halide#2: we should probably thing more carefully about using variadic templates in our public API in the future; we currently use it pretty heavily, but it tends to be messy and hard to reason about IMHO.) * tidy * remove underscores

* Fix float16 under asan, attempt halide#2 Some sneakiness going on. * Update float16_t.cpp

abadams closed this as completed Aug 5, 2012

dsharlet-intel mentioned this issue Mar 18, 2014

Enable 'vectorize' for OpenCL C target w/ vload+vstore optimization #267

Merged

gchauras mentioned this issue Jul 31, 2014

Segfault in JIT compilation #404

Closed

abestephensg mentioned this issue Nov 20, 2014

opengl_varying crashes with Failed to free device buffer #559

Closed

steven-johnson mentioned this issue Dec 2, 2014

define_extern() should make it easy to match Target::UserContext #554

Closed

abestephensg mentioned this issue Jun 5, 2015

Regression: runtime crash in test/opengl/ JIT tests #819

Closed

abadams mentioned this issue Sep 21, 2015

Debug symbol parsing crashes for programs build with Xcode 7 #936

Closed

zvookin pushed a commit that referenced this issue May 26, 2016

Merge pull request #2 from halide/master

1f7f8c4

Merge from mainline

dpalermo mentioned this issue Sep 29, 2016

Prefetch scheduling directive #1527

Merged

steven-johnson mentioned this issue Nov 18, 2016

apps/ should only rely on distrib/ folder? #1637

Closed

abadams mentioned this issue Feb 10, 2017

Add vrmpy, vdmpy, improve vmpa on Hexagon #1825

Merged

dkurt referenced this issue in dkurt/Halide Sep 5, 2017

Merge pull request #2 from dkurt/cv_samples

4630186

BGR2Gray Halide+OpenCV sample

ronlieb mentioned this issue Oct 26, 2017

Error running HelloHexagon #1444

Closed

dliang0406 mentioned this issue Nov 16, 2017

HelloHexagon Error: Not pic code 30 #2273

Closed

slomp pushed a commit that referenced this issue Feb 26, 2018

reverting accidental commit #2...

75429db

dsharletg pushed a commit that referenced this issue May 8, 2018

Merge pull request #2 from vgundlur/hex-dma2-copy-to-device-prob

b594fc5

Hex dma2 copy to device prob

abadams mentioned this issue May 30, 2018

Generating vmlal.s16 #2997

Closed

steven-johnson pushed a commit that referenced this issue Jul 27, 2018

Merge pull request #2 from halide/master

14f594e

Sync

shoaibkamil mentioned this issue Oct 10, 2018

Crash when using Halide external function in shared library and loading it in runtime dynamic linking on Linux #3327

Open

shoaibkamil pushed a commit that referenced this issue Oct 11, 2018

Dummy change #2

3f2891c

AlexanderGarmash mentioned this issue Jan 28, 2019

HelloAndroidCamera2 is crashing when camera permissions granted #3633

Open

shoaibkamil mentioned this issue May 13, 2019

Halide Releases should be more regular and more frequent #1905

Closed

chtsao8 mentioned this issue Jul 12, 2019

Onnx->Halide Conversion Issues #4007

Closed

steven-johnson mentioned this issue Aug 17, 2019

Improve (re)train_cost_model tool #4145

Merged

steven-johnson mentioned this issue Sep 12, 2019

Legal names of Vars, Funcs, etc should be well-defined/limited #4239

Open

steven-johnson mentioned this issue Mar 17, 2020

Parallelize clang-tidy runs #4731

Merged

steven-johnson added a commit that referenced this issue Aug 19, 2020

fix for trunk llvm, try #2

19d9ca4

Previous fix broke LLVM 11 (I was too eager to land, sorry)

steven-johnson added a commit that referenced this issue Aug 19, 2020

fix for trunk llvm, try #2 (#5198)

d1f34da

Previous fix broke LLVM 11 (I was too eager to land, sorry)

steven-johnson mentioned this issue Jan 28, 2021

Add initial support for Sapphire Rapids AVX512 features #5677

Merged

steven-johnson mentioned this issue Feb 18, 2021

Add initial support for RISCV RVV features #5758

Merged

steven-johnson mentioned this issue Nov 12, 2021

Fix OpenGLCompute tests #6394

Draft

brent-carmer referenced this issue in InteonCo/Halide Feb 28, 2022

Merge pull request #2 from InteonCo/awherr

de87309

Patch auto-scheduler the random seed for weight generation is configurable via the HL_RANDOM_WEIGHT_SEED env variable.

steven-johnson mentioned this issue Mar 18, 2022

Applying .split() to .fuse()'d vars produces strange results #6652

Open

This was referenced Mar 30, 2022

-mtune=/-mcpu= support for x86 AMD CPU's #6655

Merged

Define an AbstractGenerator interface #6637

Merged

RootButcher referenced this issue in RootButcher/Halide-rustbinding-old Apr 21, 2022

Merge pull request #2 from RootButcher/automake_libruntime.a

0f8bce4

Automake libruntime.a

RootButcher referenced this issue in RootButcher/Halide-rustbinding-old Apr 21, 2022

Merge pull request #2 from RootButcher/Refactored_buffers

22e6b85

Refactored buffers

steven-johnson mentioned this issue Jul 28, 2022

[vulkan phase1] Add SPIR-V IR #6882

Merged

steven-johnson added a commit that referenced this issue Aug 16, 2022

oops #2

442ffc5

steven-johnson mentioned this issue Aug 23, 2022

Fix possible overflow in saturating_cast bounds inference #6961

Closed

steven-johnson mentioned this issue Sep 13, 2022

[x86] Separate vector instruction selection and CodeGen passes #6884

Open

3 tasks

steven-johnson mentioned this issue Sep 23, 2022

add_requirement() maintenance #7045

Merged

steven-johnson added a commit that referenced this issue Jul 18, 2023

Fix float16 under asan, attempt #2

33c653f

Some sneakiness going on.

steven-johnson added a commit that referenced this issue Jul 19, 2023

Fix float16 under asan, attempt #2 (#7691)

475b774

* Fix float16 under asan, attempt #2 Some sneakiness going on. * Update float16_t.cpp

derek-gerstmann mentioned this issue Aug 3, 2023

[vulkan] Fix heap buffer overflow in Vulkan extension handling discovered by ASAN #7740

Merged

vksnk added a commit that referenced this issue Nov 6, 2023

Tests #2

7db2251

steven-johnson mentioned this issue Nov 28, 2023

fuzz-testing failure in fuzz_simplify #7962

Open

ardier pushed a commit to ardier/Halide-mutation that referenced this issue Mar 3, 2024

Fix float16 under asan, attempt halide#2 (halide#7691)

30b22e4

* Fix float16 under asan, attempt halide#2 Some sneakiness going on. * Update float16_t.cpp

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compute_remainder_modulus analysis fails for cast<int>(some float) #2

compute_remainder_modulus analysis fails for cast<int>(some float) #2

abadams commented Jul 31, 2012

abadams commented Aug 5, 2012

compute_remainder_modulus analysis fails for cast<int>(some float) #2

compute_remainder_modulus analysis fails for cast<int>(some float) #2

Comments

abadams commented Jul 31, 2012

abadams commented Aug 5, 2012