Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HexagonOffload produces needless _metadata() function #6452

Closed
steven-johnson opened this issue Nov 30, 2021 · 0 comments
Closed

HexagonOffload produces needless _metadata() function #6452

steven-johnson opened this issue Nov 30, 2021 · 0 comments

Comments

@steven-johnson
Copy link
Contributor

steven-johnson commented Nov 30, 2021 •
edited
Loading

As a side effect of going thru Codegen_LLVM, it appears that HexagonOffload is including the standard _argv() and _metadata() functions for the HVX functions; since these get embedded in a data block, they don't ever get dead-stripped and are small-but-useless. It would be nice to tweak codegen to omit them.

EDIT: _argv() is actually needed by halide_hexagoon_run(), but the metadata isn't.
@steven-johnson steven-johnson changed the title HexagonOffload produces needless _argv() & _metadata() functions HexagonOffload produces needless _metadata() function Dec 1, 2021
steven-johnson added a commit that referenced this issue Dec 2, 2021
@steven-johnson
Add LinkageType::ExternalPlusArgv (#6452)
b13dcf2 
Allows us to skip generating metadata for offloaded hexagon funcs, which will never use it.
steven-johnson added a commit that referenced this issue Dec 2, 2021
@steven-johnson
Add LinkageType::ExternalPlusArgv (#6452) (#6463)
479d839 
Allows us to skip generating metadata for offloaded hexagon funcs, which will never use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steven-johnson