Should ParamMap be Deprecated/Removed? #7121
Comments
steven-johnson
added a commit
that referenced
this issue
Feb 15, 2023
This PR proposes to remove ParamMap entirely for Halide 16; it was added to provide a threadsafe way to provide parameteres to the JIT, but `compile_to_callable()` now does this in a much less intrusive way. Normally I'd propose deprecating something like this first (eg via ifdef), but in this case it would be extremely intrusive to do so, so this PR just rips off the band-aid and removes it entirely -- feedback welcome on this.
steven-johnson
added a commit
that referenced
this issue
Feb 15, 2023
This PR deprecates ParamMap for Halide 16, with the plan of removing it entirely for Halide 17; it was added to provide a threadsafe way to provide parameteres to the JIT, but `compile_to_callable()` now does this in a much less intrusive way.
steven-johnson
added a commit
that referenced
this issue
Apr 13, 2023
* Deprecate ParamMap (#7121) This PR deprecates ParamMap for Halide 16, with the plan of removing it entirely for Halide 17; it was added to provide a threadsafe way to provide parameteres to the JIT, but `compile_to_callable()` now does this in a much less intrusive way. * Updated comments, removed mutexes (mutices?) * formatting * Go back to HALIDE_ATTRIBUTE_DEPRECATED
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this issue
Mar 3, 2024
* Deprecate ParamMap (halide#7121) This PR deprecates ParamMap for Halide 16, with the plan of removing it entirely for Halide 17; it was added to provide a threadsafe way to provide parameteres to the JIT, but `compile_to_callable()` now does this in a much less intrusive way. * Updated comments, removed mutexes (mutices?) * formatting * Go back to HALIDE_ATTRIBUTE_DEPRECATED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ParamMapwas added years ago as a way to provide thread-safety when usingrealize()and friends with the JIT. The introduction ofcompile_to_callable()in Halide 15 provides an alternate (and arguably better/cleaner) way to accomplish the same thing; therefore, I'd argue that we should consider a deprecation/removal plan for ParamMap. Would love to hear feedback from other folks on this. (Especially if use ParamMap, either now or in the past, of course.)The text was updated successfully, but these errors were encountered: