Fix linking to shared LLVM. #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
added
backport me
steven-johnson
approved these changes
Sep 30, 2020
alexreinking
force-pushed
the
build/shared-llvm-fix
branch
from
7fc2b47
to
69be4d4
Compare
Done. Added the comment inside the |
|
Does this need to run on the buildbots? |
Yes, for sure |
|
Any idea why the buildbots aren't running on this? |
|
Buildbots are very backed up after changes yesterday -- are they pending? |
|
Failure is unrelated, landing |
alexreinking
pushed a commit
that referenced
this pull request
Oct 16, 2020
Fix linking to shared LLVM.
alexreinking
removed
the
backport me
alexreinking
pushed a commit
that referenced
this pull request
Oct 18, 2020
Fix linking to shared LLVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, LLVM's own
llvm_map_components_to_libnamesfunction is busted if you build only the shared library version.This PR should fix that up and avoid calling this function when shared LLVM is requested.
We should backport this to 10.0.0 for future Deb packaging, and we probably need to add buildbot testing of shared and bundled scenarios. Maybe just the x64 linux bot can run the generator tests.
Fixes #5304.