Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AMX instructions #5818

Merged
merged 68 commits into from
Oct 21, 2021
Merged

Add support for AMX instructions #5818

merged 68 commits into from
Oct 21, 2021

Commits on Mar 16, 2021

  1. Add support for AMX tile instructions

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    036b037 View commit details
    Browse the repository at this point in the history

  2. Make AMX transform opt-in with memory type

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    2bd3453 View commit details
    Browse the repository at this point in the history

  3. Clean up tiled_matmul test

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    34e1a4c View commit details
    Browse the repository at this point in the history

  4. Handle AMX intrinsic attributes better

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    dfeac55 View commit details
    Browse the repository at this point in the history

  5. Format

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    a9f84de View commit details
    Browse the repository at this point in the history

  6. Fix test to behave like other tests

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    da04b0a View commit details
    Browse the repository at this point in the history

  7. Add doc and missing load check

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9923040 View commit details
    Browse the repository at this point in the history

  8. Format

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    1a1d10a View commit details
    Browse the repository at this point in the history

  9. Throw error if user requests AMX for invalid operation

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d54fe24 View commit details
    Browse the repository at this point in the history

  10. Add Tile lowering pass to makefile

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    228beda View commit details
    Browse the repository at this point in the history

  11. Use spaces in Makefile

    @jwlawson
    jwlawson authored and Thales Sabino committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    673480a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Place AMX instrinsics into a separate module (x86_amx.ll) 

    This will only be included if LLVM >= 12 is used to build Halide
    Thales Sabino committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    f91d79f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/5818

    @steven-johnson
    steven-johnson committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    9fc4366 View commit details
    Browse the repository at this point in the history

  3. Fix CreateAlignedLoad() call in CodeGen_X86 

    Recent changes in LLVM trunk made the previous calling convention deprecated (and thus compiling with warning/error)
    @steven-johnson
    steven-johnson committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    16a1c7b View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Merge branch 'master' into tile_matmul

    Thales Sabino committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    b3b1dfa View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Merge branch 'master' into tile_matmul

    Thales Sabino committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    03f894a View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Merge branch 'master' into tile_matmul

    Thales Sabino committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    97890dd View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Merge branch 'master' into tile_matmul

    Thales Sabino committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    293ca90 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Merge branch 'master' into tile_matmul

    Thales Sabino committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    4b950e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. fix exporting to module

    @frengels
    frengels committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d0e5123 View commit details
    Browse the repository at this point in the history

  2. add llvm funcs for su, us, uu amx variants

    @frengels
    frengels committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    9189120 View commit details
    Browse the repository at this point in the history

  3. add other amx intrinsics to intrinsic_defs

    @frengels
    frengels committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    75c4262 View commit details
    Browse the repository at this point in the history

  4. match with unsigned 8 bit integers 

    This matching happens for the left and right side,
each determining  whether that side is unsigned or signed.
In the end the proper 1024 byte buffer is created with (un)signed.
    @frengels
    frengels committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    09f7551 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. match for 32 bit integer and guard unsigned amx on llvm 13

    @frengels
    frengels committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    5dd1471 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. adjust test to cover unsigned tile operations

    @frengels
    frengels committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    7e45c29 View commit details
    Browse the repository at this point in the history

  2. guard properly with llvm 12

    @frengels
    frengels committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4ab681b View commit details
    Browse the repository at this point in the history

  3. create explicit error if failed to use tile operations

    @frengels
    frengels committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    6339ae7 View commit details
    Browse the repository at this point in the history

  4. pass types as template params rather than boolean 

    This makes the intention clearer
    @frengels
    frengels committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    525e11e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. clang-format patch

    @frengels
    Thales Sabino authored and frengels committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    5a21484 View commit details
    Browse the repository at this point in the history

  2. add x86_amx to makefile's runtime components

    @frengels
    frengels committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    7950614 View commit details
    Browse the repository at this point in the history

  3. make tiled_matmul compatible with c++11

    @frengels
    frengels committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    4a6c10c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into tile_matmul

    @frengels
    frengels committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    02c375a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. add mattrs required for amx

    @frengels
    frengels committed May 3, 2021
    Configuration menu
    Copy the full SHA
    f985644 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from frengels/tile_matmul 

    Add mattrs required for amx
    @mcleary
    mcleary committed May 3, 2021
    Configuration menu
    Copy the full SHA
    7df3d5e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. fix formatting issues

    @frengels
    frengels committed May 5, 2021
    Configuration menu
    Copy the full SHA
    e3f1ef6 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. remove outdated FIXME comments

    @frengels
    frengels committed May 10, 2021
    Configuration menu
    Copy the full SHA
    57b6080 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4 from frengels/tile_matmul 

    Addressing comments on PR
    @mcleary
    mcleary committed May 10, 2021
    Configuration menu
    Copy the full SHA
    ef9d544 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Merge branch 'master' into tile_matmul

    Thales Sabino committed May 11, 2021
    Configuration menu
    Copy the full SHA
    9c6bfbc View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Merge branch 'master' into tile_matmul

    Thales Sabino committed May 13, 2021
    Configuration menu
    Copy the full SHA
    b5c46d2 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Merge remote-tracking branch 'upstream/master' into tile_matmul

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5af3dae View commit details
    Browse the repository at this point in the history

  2. add bf16 tile operations to the runtime

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    55098f3 View commit details
    Browse the repository at this point in the history

  3. create a schedule that should map to amx

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    9f078f0 View commit details
    Browse the repository at this point in the history

  4. create full amx-bf16 schedule

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    e73702d View commit details
    Browse the repository at this point in the history

  5. allow amx operations to yield f32s

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    16217b4 View commit details
    Browse the repository at this point in the history

  6. accept 32 bit float stores

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c722610 View commit details
    Browse the repository at this point in the history

  7. add support for bf16

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    66885f1 View commit details
    Browse the repository at this point in the history

  8. add missing bf16 intrinsics

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    97fb022 View commit details
    Browse the repository at this point in the history

  9. fix striding error when loading matrix

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f6ba739 View commit details
    Browse the repository at this point in the history

  10. add checks to verify bf16 result

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c7278b6 View commit details
    Browse the repository at this point in the history

  11. fix scaling of col_bytes on matmul call

    @frengels
    frengels committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5e81a72 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. move brace to previous line

    @frengels
    frengels committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    ea74fe2 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. derive result type using a function rather than lambda

    @frengels
    frengels committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    a854dc9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into tile_matmul_bf16

    @frengels
    frengels committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    d820737 View commit details
    Browse the repository at this point in the history

  3. run clang tidy and format

    @frengels
    frengels committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    26014d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. have tile_store return i32

    @frengels
    frengels committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    34557cb View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. make is_3d_tile_index robust to indexing changes

    @frengels
    frengels committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    5ad06e0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into tile_matmul_bf16

    @frengels
    frengels committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    f0f9f3e View commit details
    Browse the repository at this point in the history

  3. apply formatting suggestions

    @frengels
    frengels committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    7cab155 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. both first and second can be const qualified

    @frengels
    frengels committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8f83544 View commit details
    Browse the repository at this point in the history

  2. remove trailing whitespace in unformatted section

    @frengels
    frengels committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    b1e1452 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Merge branch 'master' into pr/5818

    @steven-johnson
    steven-johnson committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    95d38f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. make requested style changes

    @frengels
    frengels committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    14df0bc View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. rename NewMatmul -> Matmul

    @frengels
    frengels committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    8b63d77 View commit details
    Browse the repository at this point in the history

  2. fix warning about missing return value

    @frengels
    frengels committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    6a5eeaa View commit details
    Browse the repository at this point in the history

  3. use get_1d_tile_index to handle special case 

    When using `Buffer` instead of `ImageParam` the `Ramp` expression
generated is 1D instead of 2D, therefore we recognize this with a special
case. The lanes are still matched against the dimensions of the LHS
3d tile lanes.
    @frengels
    frengels committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    cc7c97d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. add correctness test for AMX instructions

    @frengels
    frengels committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    014f0c6 View commit details
    Browse the repository at this point in the history

  2. correctness part has been separated out

    @frengels
    frengels committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    655dbdf View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. remove unused variables

    @frengels
    frengels committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    abc660b View commit details
    Browse the repository at this point in the history