-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename halide_assert -> halide_abort_if_false #6382
Merged
Merged
Commits on Nov 3, 2021
-
Rename halide_assert -> HALIDDE_CHECK
A crashing bug got mistakenly inserted because a new contributor (reasonably) assumed that the `halide_assert()` macro in our runtime code was like a C `assert()` (i.e., something that would vanish in optimized builds). This is not the case; it is a check that happens in all build modes and always triggers an `abort()` if it fires. We should remove any ambiguity about it, so this proposes to rename it to somethingmore like the Google/Abseil-style CHECK() macro, to make it stand out more. (We may want to do a followup to verify that all of the uses really are unrecoverable errors that aren't better handled by returning an error.)
Configuration menu - View commit details
-
Copy full SHA for e43c196 - Browse repository at this point
Copy the full SHA e43c196View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd0b065 - Browse repository at this point
Copy the full SHA cd0b065View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0189766 - Browse repository at this point
Copy the full SHA 0189766View commit details -
Configuration menu - View commit details
-
Copy full SHA for a251f2e - Browse repository at this point
Copy the full SHA a251f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41b2c1a - Browse repository at this point
Copy the full SHA 41b2c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3833cc8 - Browse repository at this point
Copy the full SHA 3833cc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9db8e1 - Browse repository at this point
Copy the full SHA d9db8e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7044520 - Browse repository at this point
Copy the full SHA 7044520View commit details -
Configuration menu - View commit details
-
Copy full SHA for a22d682 - Browse repository at this point
Copy the full SHA a22d682View commit details
Commits on Nov 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 101f8ca - Browse repository at this point
Copy the full SHA 101f8caView commit details -
Configuration menu - View commit details
-
Copy full SHA for c10ba5e - Browse repository at this point
Copy the full SHA c10ba5eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.