Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename halide_assert -> halide_abort_if_false #6382

Merged
merged 11 commits into from
Nov 8, 2021
Merged

Commits on Nov 3, 2021

  1. Rename halide_assert -> HALIDDE_CHECK

    A crashing bug got mistakenly inserted because a new contributor (reasonably) assumed that the `halide_assert()` macro in our runtime code was like a C `assert()` (i.e., something that would vanish in optimized builds).
    
    This is not the case; it is a check that happens in all build modes and always triggers an `abort()` if it fires. We should remove any ambiguity about it, so this proposes to rename it to somethingmore like the Google/Abseil-style CHECK() macro, to make it stand out more.
    
    (We may want to do a followup to verify that all of the uses really are unrecoverable errors that aren't better handled by returning an error.)
    steven-johnson committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e43c196 View commit details
    Browse the repository at this point in the history
  2. clang-format

    steven-johnson committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    cd0b065 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0189766 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a251f2e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    41b2c1a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3833cc8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d9db8e1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7044520 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a22d682 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Configuration menu
    Copy the full SHA
    101f8ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c10ba5e View commit details
    Browse the repository at this point in the history