Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert various halide_assert -> static_assert #6383

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

steven-johnson
Copy link
Contributor

The type-size checks in d3d12compute.cpp don't need to be runtime checks.

The type-size checks in d3d12compute.cpp don't need to be runtime checks.
Copy link
Contributor

@shoaibkamil shoaibkamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@slomp slomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see we're moving forward with a more modern C++ standard!

@steven-johnson
Copy link
Contributor Author

Failures are unrelated.

@steven-johnson steven-johnson merged commit 7ec8d70 into master Nov 3, 2021
@steven-johnson steven-johnson deleted the srj/static-asserts branch November 3, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants