Fail if no_bounds_query specified for HL_JIT_TARGET #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIT requires the use of bounds_query; disabling it will almost certainly fail in JIT mode, either with a confusing assert message, or a crash (if you also specify no_asserts). This adds a more useful failure message.
abadams
reviewed
Dec 9, 2021
src/Target.cpp
Outdated
| @@ -431,6 +431,8 @@ Target get_jit_target_from_environment() { | |||
| << "HL_JIT_TARGET must match the host OS, architecture, and bit width.\n" | |||
| << "HL_JIT_TARGET was " << target << ". " | |||
| << "Host is " << host.to_string() << ".\n"; | |||
| user_assert(!t.has_feature(Target::NoBoundsQuery)) | |||
| << "The Halide JIT requires the use of bounds query, but HL_JIT_TARGET was specified with no_bunds_query: " << target; | |||
abadams
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT requires the use of bounds_query; disabling it will almost certainly fail in JIT mode, either with a confusing assert message, or a crash (if you also specify no_asserts). This adds a more useful failure message.