Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing case in clamp_unsafe_accesses #6508

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

abadams
Copy link
Member

@abadams abadams commented Dec 21, 2021

No description provided.

Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@alexreinking
Copy link
Member

alexreinking commented Dec 21, 2021

Looks like the crash must be happening here:

auto​ bounds = func_bounds.​at​({call->​name​, call->​value_index​});

Is there some reason a Call::Image would not be included in the FuncValueBounds results?

@abadams
Copy link
Member Author

abadams commented Dec 21, 2021

Yeah, we don't know the value bounds of input images. I pushed something that better reflects what I was trying to do.

@alexreinking
Copy link
Member

Great, yeah, that looks better

@alexreinking alexreinking merged commit e7f655b into master Dec 22, 2021
@alexreinking alexreinking deleted the abadams/clamp_unsafe_access_fix branch December 22, 2021 02:41
alexreinking pushed a commit that referenced this pull request Jan 5, 2022
* Fix a missing case in clamp_unsafe_accesses

* Don't check func_value_bounds of images

(cherry picked from commit e7f655b)
alexreinking pushed a commit that referenced this pull request Jan 6, 2022
* Fix a missing case in clamp_unsafe_accesses

* Don't check func_value_bounds of images

(cherry picked from commit e7f655b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants