Make HALIDE_REGISTER_GENERATOR work with multiple template args #6556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
approved these changes
Jan 12, 2022
Comment on lines
+16
to
+20
| // A major downside of templated generators is that because we use CRTP, you | ||
| // must manually import names of types from the base class. For Input and | ||
| // Output you can also just use these equivalent globally-scoped names: | ||
| GeneratorInput<Buffer<T1>> input{"input", 2}; | ||
| GeneratorOutput<Buffer<T2>> output{"output", 2}; |
There was a problem hiding this comment.
I helped someone with this exact issue on StackOverflow not too long ago... https://stackoverflow.com/a/70071173/2137996
Maybe it would be helpful to document an example of this somewhere?
|
Windows failures: |
|
failures are unrelated, good to land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the macro uses the type in a way that fails if it's enclosed in parens, which is necessary if the type name contains internal commas due to template usage.