Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for top-of-tree LLVM #6561

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Fix for top-of-tree LLVM #6561

merged 2 commits into from
Jan 13, 2022

Conversation

steven-johnson
Copy link
Contributor

No description provided.

alexreinking
alexreinking approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it would be good to leave a comment explaining what the difference is here and why it matters to LLVM

@steven-johnson steven-johnson merged commit a86e13d into master Jan 13, 2022
@steven-johnson steven-johnson deleted the srj/win32-layout-fix branch January 13, 2022 23:34
steven-johnson added a commit that referenced this pull request Jan 16, 2022
@steven-johnson
Revert "Fix for top-of-tree LLVM (#6561)"
cd6c6b3 
This reverts commit a86e13d.
@steven-johnson steven-johnson mentioned this pull request Jan 16, 2022
Merged
steven-johnson added a commit that referenced this pull request Jan 17, 2022
@steven-johnson
Revert "Fix for top-of-tree LLVM (#6561)" (#6564)
cf4565b 
This reverts commit a86e13d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexreinking alexreinking alexreinking approved these changes

@abadams abadams Awaiting requested review from abadams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steven-johnson @alexreinking