Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wild match object should not be foldable #6623

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Wild match object should not be foldable #6623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
304285d
Wild match object is not foldable
rootjalex Feb 19, 2022
45afc3c
Merge branch 'main' of github.com:halide/Halide into rootjalex/wild-n…
rootjalex Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions src/IRMatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,30 +486,7 @@ struct Wild {
return state.get_binding(i);
}

constexpr static bool foldable = true;
HALIDE_ALWAYS_INLINE
void make_folded_const(halide_scalar_value_t &val, halide_type_t &ty, MatcherState &state) const noexcept {
const auto *e = state.get_binding(i);
ty = e->type;
switch (e->node_type) {
case IRNodeType::UIntImm:
val.u.u64 = ((const UIntImm *)e)->value;
return;
case IRNodeType::IntImm:
val.u.i64 = ((const IntImm *)e)->value;
return;
case IRNodeType::FloatImm:
val.u.f64 = ((const FloatImm *)e)->value;
return;
default:
// The function is noexcept, so silent failure. You
// shouldn't be calling this if you haven't already
// checked it's going to be a constant (e.g. with
// is_const, or because you manually bound a constant Expr
// to the state).
val.u.u64 = 0;
}
}
constexpr static bool foldable = false;
};

template<int i>
Expand Down