python_bindings: Fix SIGSEGV in HalidePythonCompileTimeErrorReporter #6635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I realize
g
in the snippet below, I get a SIGSEGV inPyErr_Occurred
. This example is run with python bindings fromrelease/13.x
branch.Expected: I see the warning
Actual: SIGSEGV
I added a
py::gil_scoped_acquire
before printing similar tohalide_python_print()
inPyError.cpp
and this fixes the output. Should I release the GIL?After the fix