Fix subtle CMake Install bugs #7103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
added
the
backport me
abadams
approved these changes
Oct 19, 2022
steven-johnson
added a commit
that referenced
this pull request
Oct 24, 2022
* Update CMakeLists.txt * Update CMakeLists.txt
steven-johnson
added a commit
that referenced
this pull request
Oct 24, 2022
* Update CMakeLists.txt * Update CMakeLists.txt
steven-johnson
added a commit
that referenced
this pull request
Oct 24, 2022
* Update CMakeLists.txt * Update CMakeLists.txt
steven-johnson
added a commit
that referenced
this pull request
Oct 24, 2022
* Generate dot() in the Metal backend (#7085) * dot() support for Metal backend) * Restrict dot() to floats * Fix subtle CMake Install bugs (#7103) * Update CMakeLists.txt * Update CMakeLists.txt * Fix some dead links to the 'master' branch (#7107) * Attempt to fix pip build issues (#7098) * Add evaluate() and evaluate_may_gpu() to Python bindings (#7108) * Add evaluate() and evaluate_may_gpu() to Python bindings * pacify clang-tidy Co-authored-by: Volodymyr Kysenko <vksnk@google.com> Co-authored-by: Andrew Adams <andrew.b.adams@gmail.com>
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Update CMakeLists.txt * Update CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WITH_UTILoption was relied upon inside the autoscheduler subdir, but wasn't defined until after that subdir was processed. This had the unfortunate effect of making the undefined option (effectively) always false the first time it was encountered, but appropriately true | false on subsequent runs; the upshot was that if you did amake installas the FIRST build from a build-from-scratch, you would (quietly) get an install that omitted the adams2019 tools from the installer. (This seems like a crazy misfeature on CMake's part, but I'm sure it's unfixable now...)