Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up various autoscheduler tool issues #7483

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Commits on Apr 6, 2023

  1. Clean up various autoscheduler tool issues

    - In CMake, not all of the tooling for Anderson2021 was included in packaging; now it is.
    - Since the featurization_to_sample and get_host_target tools are 100% identical across all autoschedulers, they now get build only once, and don't get the `adams2019_` (etc) prefix they formerly did.
    - conversely, the autotune_loop.sh and weightsdir_to_weightsfile tools now *do* get autoscheduler-specific prefixes, because they aren't interchangeable.
    - Fixes to various scripts etc to use the correct tool names.
    - When the Anderson2021 autoscheduler was added, we tried to factor out common coding and tooling, but went a bit too far: the weightsdir_to_weightsfile source was moved into common/, and while it and the related Weights source were identical, they needed to include *different* Featurization.h files, and so basically relied on the build rules building it twice, with a different include path each time. IMHO this is unreasonably fragile and weird, so I moved those sources back into the folders in question, as there isn't any compelling reason to keep these sources exactly in sync anyway.
    - Same story for the test_function_dag test.
    
    Note that I started to add support for Anderson2021 to the main Makefile, but it became painful to do -- it works fine for CMake, so I will leave adding Make support for someone who wants to use it there.
    steven-johnson committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    690a55d View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Fix needless renames

    steven-johnson committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    f44ab81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7741f4 View commit details
    Browse the repository at this point in the history
  3. Update CMakeLists.txt

    steven-johnson committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    a483b4f View commit details
    Browse the repository at this point in the history
  4. Update Makefile

    steven-johnson committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    f5cdecc View commit details
    Browse the repository at this point in the history