Use a find-module to locate Dawn/WebGPU #7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
approved these changes
Apr 19, 2023
alexreinking
commented
Apr 19, 2023
Comment on lines
+721
to
+722
| find_package(Halide_WebGPU REQUIRED) | ||
| target_link_libraries(${TARGET} ${VISIBILITY} Halide::WebGPU) |
There was a problem hiding this comment.
If Dawn provided a first-party CMake package, we would only need to write:
find_package(Dawn REQUIRED)
target_link_libraries(${TARGET} ${VISIBILITY} Dawn::Dawn)
here, and there would be no other changes.
There was a problem hiding this comment.
Tagging @jrprice as an FYI.
steven-johnson
added
the
buildbot_test_everything
|
...why aren't the buildbots running on this? |
Maybe because it's a pr-to-pr? |
ahhh, gotcha, let's land it then I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might want to add some documentation in
README_webgpu.mdfor how AOT compilation works.