Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted may_subtile checks #7626

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix inverted may_subtile checks #7626

merged 1 commit into from
Jun 13, 2023

Conversation

abadams
Copy link
Member

@abadams abadams commented Jun 12, 2023

This was massively restricting the search space of the autoscheduler, making it faster but excluding most interesting schedules (e.g. all sliding window ones).

Fixes #7531
May also relate to #7623

@abadams abadams added autoscheduler Related to one or more of the Autoschedulers backport me This change should be backported to release versions release_notes For changes that may warrant a note in README for official releases. labels Jun 12, 2023
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this was a pretty big mistake on my part :-/

@abadams
Copy link
Member Author

abadams commented Jun 12, 2023

Wow, this was a pretty big mistake on my part :-/

More like a weakness in our testing for the autoschedulers.

@abadams
Copy link
Member Author

abadams commented Jun 13, 2023

Failures unrelated

@abadams abadams merged commit fa3d87c into main Jun 13, 2023
@abadams
Copy link
Member Author

abadams commented Jun 13, 2023

@derek-gerstmann This fixed the issue blocking the 16 release

@derek-gerstmann
Copy link
Contributor

@abadams Thx! I'll start coordinating the v16 branch and prepare things for the release!

ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoscheduler Related to one or more of the Autoschedulers backport me This change should be backported to release versions release_notes For changes that may warrant a note in README for official releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use correctly the new autoscheduler api?
3 participants