Fixed the regularization for BGU. #7684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To compare the image I reported originally: (before) https://user-images.githubusercontent.com/845012/253539155-09c73346-563f-4580-b781-089f4b0068ad.jpg (after) https://user-images.githubusercontent.com/845012/253946895-792e6941-8cb4-475d-9a6c-95d48857d99c.jpg Open both and toggle back and forth in two tabs. Result looks identical, except for the regularization artifacts. |
|
Your argument about the original regularization makes sense to me. I'd appreciate @jiawen 's take on it though. |
|
ASAN failures are unrelated |
|
Ready to merge? |
abadams
approved these changes
Jul 24, 2023
|
🥳 |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
Co-authored-by: Steven Johnson <srj@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #7681.
This patch simplifies the regularization. The most important takeaway is in the comment of the changed code, and a thought I had: #7681 (comment) :
@jiawen @abadams I don't know if you want to validate the result by running the experiment setup of your paper? I guess that will be a more formal test.