Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float16 warning for older clangs #7701

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix float16 warning for older clangs #7701

merged 1 commit into from
Jul 25, 2023

Conversation

abadams
Copy link
Member

@abadams abadams commented Jul 24, 2023

This routine was missing a float cast when compiled with older clangs. Also removed the warning, because I have now tested it.

steven-johnson
steven-johnson approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@steven-johnson
Copy link
Contributor

Failures are unrelated

@steven-johnson steven-johnson merged commit c9bf3b1 into main Jul 25, 2023
3 checks passed
@steven-johnson steven-johnson deleted the abadams/remove_float16_t_warning branch July 25, 2023 20:29
@BrewTestBot BrewTestBot mentioned this pull request Feb 2, 2024
Closed
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@abadams @ardier
Fix float16 warning for older clangs (halide#7701)
40117d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abadams @steven-johnson