Fix leaks in test/correctness/memoize.cpp #7705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by explicitly releasing the shared runtime at the end of the test
…fix_leaks_in_memoize_test
steven-johnson
changed the base branch from
main
to
abadams/remove_parameter_self_references
steven-johnson
changed the base branch from
abadams/remove_parameter_self_references
to
main
steven-johnson
approved these changes
Jul 25, 2023
…m/halide/Halide into abadams/fix_leaks_in_memoize_test
It requires _aligned_free, which the runtime aint gonna do
|
Looks like an error on correctness_memoize on Windows... https://buildbot.halide-lang.org/master/#/builders/148/builds/60 |
On windows mixing and matching mallocs and frees doesn't work well.
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Fix leaks caused by self-referential parameter constraints * Add comment * Add missing overrides * Fix reported leaks in memoize test by explicitly releasing the shared runtime at the end of the test * Use const refs for non-mutated args * Hopefully fix for windows * Fix for 32-bit pointers * Don't use _aligned_malloc It requires _aligned_free, which the runtime aint gonna do * Fix other memoize test * Use runtime built-in malloc/free On windows mixing and matching mallocs and frees doesn't work well. * Fix comment --------- Co-authored-by: Steven Johnson <srj@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a little tricky, because it turns out any custom allocator used with memoized allocations needs to be compatible with the vanilla halide_free, because that's what's going to get called when the runtime shuts down.
Edit: The above issue is now resolved by just digging out the malloc/free from the runtime and wrapping them. Making a compatible one just didn't work on windows, as the malloc that gets called from the test seems to be different to the malloc that is resolved by the JIT-compiled runtime.
Built on #7700