Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the meaning of Shuffle::is_broadcast() #8158

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Clarify the meaning of Shuffle::is_broadcast() #8158

merged 3 commits into from
Apr 5, 2024

Commits on Mar 14, 2024

  1. Fix horrifying bug in lossless_cast of a subtract

    @abadams
    abadams committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7d80f8b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. A 'broadcast' shuffle is more complex than it seems 

    I was poking at the Shuffle node, and checking its usage, and it seems
that despite the comment, Shuffles that return true for is_broadcast are
not the same as a Broadcast node. Instead of repeating the input vector
some number of times, it repeats a shuffle of the input vector. This
means IRPrinter was incorrect. None of the other usages were bad.

This PR makes this clearer in the comment, and fixes IRPrinter.
    @abadams
    abadams committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    59d6462 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Revert accidental change

    @abadams
    abadams committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d13bfa8 View commit details
    Browse the repository at this point in the history