Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect output in Python tutorial, lesson 5 #8331

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

qqaatw
Copy link
Contributor

@qqaatw qqaatw commented Jun 27, 2024

This is column-major so y should vary faster than x.

The equivalent c++ code:

for (int x = 0; x < 4; x++) {
for (int y = 0; y < 4; y++) {
printf("Evaluating at x = %d, y = %d: %d\n", x, y, x + y);
}
}

@abadams
Copy link
Member

abadams commented Jun 27, 2024

Nice catch, thanks

@abadams abadams requested a review from halidebuildbots June 27, 2024 17:13
@alexreinking alexreinking merged commit 461c128 into halide:main Jun 28, 2024
16 checks passed
@alexreinking alexreinking changed the title Fix tutorial Fix incorrect output in Python tutorial, lesson 5 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants