Add RuntimeLibraryInfo to pass pipeline for LLVM >= 22 #8892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm/llvm-project#168622 adds a new analysis for determining what libcalls are supported by a target. We need to add it to the Halide pass pipeline, otherwise all libcalls are marked unsupported. This results in some memory libcalls being lowered to loops instead, which can increase runtime. This manifested for us as timeouts for the web assembly tests due to the WABT interpreter taking significantly longer to interpret memset loops versus the libcall.
Member
|
The wasm failures in the other PRs are a timeout in the rfactor tests, and this PR doesn't have them, so it seems reasonable to conclude this PR is the fix for those failures. The arm-32 failure is unrelated (llvm main seems to not currently be building on that platform). I saw a webgpu failure on osx-x86-64 which may or may not have been a flake, so I'm rerunning it to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#168622 adds a new analysis for determining what libcalls are supported by a target. We need to add it to the Halide pass pipeline, otherwise all libcalls are marked unsupported. This results in some memory libcalls being lowered to loops instead, which can increase runtime. This manifested for us as timeouts for the web assembly tests due to the WABT interpreter taking significantly longer to interpret memset loops versus the libcall.