Add autolink (linkify) functionality to Markdown #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| ) | ||
| .build() | ||
| } | ||
|
|
||
| val astRootNode by produceState<AstNode?>(null, text) { | ||
| val astRootNode by produceState<AstNode?>(null, text, options) { |
There was a problem hiding this comment.
parser should be a key to this produceState since it can change according to options.
There was a problem hiding this comment.
Good catch! I had used options as the key for parser above, and for some reason re-used the same key here instead of using parser 🤦
| val autolink: Boolean | ||
| ) { | ||
| public companion object { | ||
| public fun getDefaults(): MarkdownParseOptions = MarkdownParseOptions( |
There was a problem hiding this comment.
nit; you can make this a Default val instead of re-allocating with every function call
Adds MarkdownParseOptions which allows consumers of the library to control whether or not the autolink functionality is enabled. Note the behaviour change: autolink is enabled with the new MarkdownParseOptions defaults.
morrisseyai
force-pushed
the
feature/autolink-markdown
branch
from
2eef844 to
9556d65
Compare
|
Thanks 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates the commonmark-java dependency to 0.20.0 and introduces autolink (linkify) functionality.
I have added
MarkdownParseOptionswhich allows consumers of the library to control whether or not the autolink functionality is enabled. Addresses #95Note: autolink is enabled with the new MarkdownParseOptions defaults, which means there is a minor (but worth mentioning) behaviour change here.
Short demo:
device-2022-10-22-135749.mp4