Skip to content

BugFix: Full-bleed markdown image fix #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

vitorpamplona
Copy link
Contributor

Similar to #113, but without an option, since it seems that the correct way to display ![]() images is with fillwidth

This PR forces Coil to request the picture's original size in order to correctly render images inside a markdown paragraph.

Before After
Screenshot_20230610-171926 Screenshot_20230610-171905

Verified

This commit was signed with the committer’s verified signature. The key has expired.
nirinchev Nikola Irinchev
…d in bigger sizes than just the line height.
@halilozercan
Copy link
Owner

how would this look in a markdown document rendered on desktop or in a landscape mode tablet?

@vitorpamplona
Copy link
Contributor Author

It maxes out in the image size (it doesn't scale it)

Screenshot 2023-06-10 at 7 12 30 PM

@vitorpamplona
Copy link
Contributor Author

Desktop app also works:

Screen.Recording.2023-06-10.at.7.21.02.PM.mov

@juliangerhards
Copy link

Can we merge this now?

@halilozercan halilozercan merged commit 6e9d61d into halilozercan:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants