Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: post editing #439

Merged
merged 9 commits into from
Feb 20, 2022
Merged

refactor: post editing #439

merged 9 commits into from
Feb 20, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 16, 2022 •
edited
Loading

halo-dev/halo#1958

  1. 取消保存草稿的按钮，后续改为在文章设置中提供选项。
  2. 支持显示当前是否有未发布内容的特性。
  3. 优化预览功能。

依赖于 halo-dev/halo#1617 ，需要等待此 PR 合并。

Signed-off-by: Ryan Wang i@ryanc.cc

@ruibaby
refactor: post editing
728b148 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 16, 2022
@ruibaby ruibaby added this to the 1.5.x milestone Feb 16, 2022
@ruibaby ruibaby self-assigned this Feb 16, 2022
@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG February 16, 2022 09:27
@ruibaby ruibaby marked this pull request as draft February 16, 2022 09:27
@guqing
Copy link
Member

guqing commented Feb 16, 2022 •
edited
Loading

hi @ruibaby, Ctrl + s / command + s 保存时建议增加一个message提示来让用户知道保存已经生效

@ruibaby
feat: add saved alert
c3751ad 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
feat: add saved tips
f9568c2 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
feat: add debounce to save draft method
e01ffcd 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
refactor: saved tips
d99d6fc 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@guqing
Copy link
Member

guqing commented Feb 17, 2022

发布后重新点进去控制台会报错：
image

@ruibaby
refactor: saved tips
576144c 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member Author

ruibaby commented Feb 17, 2022 •
edited
Loading

@guqing done

@guqing
Copy link
Member

guqing commented Feb 17, 2022

保存内容后应该重新获取 isInProgress的值赋值给前端变量用于展示
image

@ruibaby
feat: update isInProcess field after saved draft
6523066 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby marked this pull request as ready for review February 17, 2022 08:01
guqing
guqing suggested changes Feb 17, 2022
View reviewed changes
src/views/post/PostEdit.vue Outdated Show resolved Hide resolved
@ruibaby
feat: update isInProcess field after saved draft
180fa9c 
Signed-off-by: Ryan Wang <i@ryanc.cc>
guqing
guqing approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruibaby ruibaby changed the title refactor: post editing WIP: refactor: post editing Feb 17, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Feb 18, 2022

/cc @JohnNiang

@guqing
Copy link
Member

guqing commented Feb 18, 2022

@ruibaby 上游PR做了更改，现在需要将isInProcess改为 inProgress

@ruibaby
refactor: isInProgress to inProgress
fb40e48 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member Author

ruibaby commented Feb 18, 2022 •
edited
Loading

@ruibaby 上游PR做了更改，现在需要将isInProcess改为 inProgress

已修改。

@ruibaby ruibaby changed the title WIP: refactor: post editing refactor: post editing Feb 20, 2022
@ruibaby ruibaby merged commit 460f770 into halo-dev:master Feb 20, 2022
@ruibaby ruibaby deleted the refactor/post-editing branch February 20, 2022 14:38
@ruibaby ruibaby mentioned this pull request Feb 21, 2022
Merged
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
refactor: post editing (halo-dev/console#439)
6ed208e 
* refactor: post editing

Signed-off-by: Ryan Wang <i@ryanc.cc>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guqing guqing guqing approved these changes

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@ruibaby ruibaby

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
1.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ruibaby @guqing