Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: adding the necessary validation to the forms #701

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 22, 2022

What type of PR is this?

/kind improvement
/milestone 2.0

What this PR does / why we need it:

完善 Console 中表单的验证规则。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2733

Special notes for your reviewer:

/cc @halo-dev/sig-halo-console

Does this PR introduce a user-facing change?

完善 Console 中表单的验证规则。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Nov 22, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Nov 22, 2022
@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 6:16AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 906fdf7 into halo-dev:main Nov 23, 2022
@ruibaby ruibaby deleted the perf/form-validation branch November 23, 2022 03:01
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
)

#### What type of PR is this?

/kind improvement
/milestone 2.0

#### What this PR does / why we need it:

完善 Console 中表单的验证规则。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2733

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

#### Does this PR introduce a user-facing change?

```release-note
完善 Console 中表单的验证规则。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端需要对部分表单项添加必要的验证
3 participants