Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add query attachments by ungrouped parameter support #706

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 24, 2022

What type of PR is this?

/kind feature
/milestone 2.0

What this PR does / why we need it:

附件管理支持通过参数筛选出未分组的附件。适配 halo-dev/halo#2752

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2451

Special notes for your reviewer:

/cc @halo-dev/sig-halo-console

测试方式:

  1. Halo 需要切换到 Provide ungrouped query param to filter ungrouped attachments halo#2752 分支。
  2. Console 需要 pnpm install
  3. 上传若干未分组附件,然后切换到未分组的标签,检查是否查询正确。
  4. 将部分附件移动至某个分组,在切换到未分组的标签,检查附件是否正确。

Does this PR introduce a user-facing change?

附件管理支持未分组的筛选条件。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 24, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Nov 24, 2022
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2022
@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 6:56AM (UTC)

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@guqing
Copy link
Member

guqing commented Nov 24, 2022

/ping @halo-dev/sig-halo-console

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit fb4499a into halo-dev:main Nov 24, 2022
@ruibaby ruibaby deleted the feat/attachment-query-by-ungrouped branch November 24, 2022 13:25
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…console#706)

#### What type of PR is this?

/kind feature
/milestone 2.0

#### What this PR does / why we need it:

附件管理支持通过参数筛选出未分组的附件。适配 halo-dev#2752

#### Which issue(s) this PR fixes:

Fixes halo-dev#2451

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

测试方式:

1. Halo 需要切换到 halo-dev#2752 分支。
2. Console 需要 `pnpm install`
3. 上传若干未分组附件,然后切换到未分组的标签,检查是否查询正确。
4. 将部分附件移动至某个分组,在切换到未分组的标签,检查附件是否正确。

#### Does this PR introduce a user-facing change?


```release-note
附件管理支持未分组的筛选条件。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

上传附件未出现在默认的未分组中
3 participants