This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
perf: asynchronously load the emoji data of the comment reply component #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…nt (halo-dev/console#798) #### What type of PR is this? /kind improvement #### What this PR does / why we need it: 优化评论回复组件的 emoji 数据加载，改为异步的方式。 构建结果对比： 优化前： <img width="475" alt="image" src="https://user-images.githubusercontent.com/21301288/209430764-25e42624-25d7-4466-a184-4fc82d310e12.png"> 优化后： <img width="473" alt="image" src="https://user-images.githubusercontent.com/21301288/209430752-1bc064e5-f3bd-42f4-b93c-8f2e200a00e3.png"> 首次请求对比： 优化前： <img width="1067" alt="image" src="https://user-images.githubusercontent.com/21301288/209430904-79c9c403-a627-44ea-a97b-13e653230b23.png"> 优化后： <img width="1066" alt="image" src="https://user-images.githubusercontent.com/21301288/209430936-e446659c-a20a-437c-bd9f-4408279410af.png"> 最终会在打开 emoji 组件的时候才加载 emoji 数据： <img width="1460" alt="image" src="https://user-images.githubusercontent.com/21301288/209430963-f2cb66c6-c0e3-4cc5-8906-66db94d40ca8.png"> #### Which issue(s) this PR fixes: Fixes halo-dev#3039 #### Special notes for your reviewer: 测试方式： 1. 检查回复组件的 Emoji 选择功能是否正常即可。 #### Does this PR introduce a user-facing change? ```release-note Console 端的评论回复 Emoji 组件数据改为异步加载，优化整体的加载性能。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
优化评论回复组件的 emoji 数据加载，改为异步的方式。
构建结果对比：
优化前：
优化后：
首次请求对比：
优化前：
优化后：
最终会在打开 emoji 组件的时候才加载 emoji 数据：
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3039
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?