Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: the width of the code input type is not full #838

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: the width of the code input type is not full #838

merged 1 commit into from
Feb 7, 2023

Conversation

infanx
Copy link
Contributor

@infanx infanx commented Feb 6, 2023 •
edited by ruibaby
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复 Console 端 FormKit 的 Code 输入类型宽度异常

Which issue(s) this PR fixes:

Fixes # halo-dev/halo#3227

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复 Console 端 FormKit 的 Code 输入框宽度未占满的问题

@vercel
Copy link

vercel bot commented Feb 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 2:35PM (UTC)

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 6, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove February 6, 2023 14:34
@ruibaby ruibaby changed the title 修复 Console 端 FormKit 的 Code 输入类型宽度异常 fix: the width of the code input type is not full Feb 6, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 6, 2023
ruibaby
ruibaby approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for your first contribution!

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
guqing
guqing reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@guqing
Copy link
Member

guqing commented Feb 7, 2023

Hi @infanx，在合并前需要先根据 #838 (comment) 签署一下CLA

@f2c-ci-robot f2c-ci-robot bot merged commit 47d2b81 into halo-dev:main Feb 7, 2023
@ruibaby ruibaby mentioned this pull request Feb 7, 2023
Closed
@ruibaby ruibaby added this to the 2.3.x milestone Feb 7, 2023
@ruibaby
Copy link
Member

ruibaby commented Feb 10, 2023

/cherry-pick release-2.2

@halo-dev-bot halo-dev-bot mentioned this pull request Feb 10, 2023
Merged
@halo-dev-bot
Copy link

@ruibaby: new pull request created: #843

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 10, 2023
@halo-dev-bot
[release-2.2] fix: the width of the code input type is not full (#843)
996eac8 
This is an automated cherry-pick of #838

/assign ruibaby

```release-note
修复 Console 端 FormKit 的 Code 输入框宽度未占满的问题
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 10, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@infanx
fix: the width of the code input type is not full (halo-dev/console#838)
8343677 
#### What type of PR is this?
/kind bug


#### What this PR does / why we need it:
修复 Console 端 FormKit 的 Code 输入类型宽度异常

#### Which issue(s) this PR fixes:

Fixes # halo-dev#3227

#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端 FormKit 的 Code 输入框宽度未占满的问题
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@wzrove wzrove Awaiting requested review from wzrove

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@infanx @CLAassistant @guqing @ruibaby @halo-dev-bot