Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: provide Chinese translation for the system's role template #870

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

为系统内提供的角色模板提供中文翻译。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2848

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. 需要 pnpm install
  2. 检查角色详情页面和新建页面的角色模板描述是否为中文。

Does this PR introduce a user-facing change?

Console 端为系统内提供的角色模板提供中文翻译

@vercel
Copy link

vercel bot commented Feb 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 4:23AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 20, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and QuentinHsu February 20, 2023 09:42
@ruibaby ruibaby added this to the 2.3.x milestone Feb 20, 2023
@JohnNiang JohnNiang modified the milestones: 2.3.x, 2.3.0 Feb 20, 2023
@LIlGG
Copy link
Member

LIlGG commented Feb 21, 2023

image

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c03ea64 into halo-dev:main Feb 21, 2023
@ruibaby ruibaby deleted the feat/rbac-translate branch February 21, 2023 05:17
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…o-dev/console#870)

#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

为系统内提供的角色模板提供中文翻译。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2848

#### Screenshots:

<img width="1414" alt="image" src="https://user-images.githubusercontent.com/21301288/220069394-6af6922b-28b2-4818-ab58-dcfb69b6b53b.png">


#### Special notes for your reviewer:

测试方式:

1. 需要 `pnpm install`
2. 检查角色详情页面和新建页面的角色模板描述是否为中文。

#### Does this PR introduce a user-facing change?

```release-note
Console 端为系统内提供的角色模板提供中文翻译
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

汉化角色权限
4 participants